fix: EnumCaseToPascalCaseRector bugs#7278
Conversation
calebdw
force-pushed
the
calebdw/push-utwsxnywtlln
branch
from
e205535 to
70b25a3
Compare
calebdw
force-pushed
the
calebdw/push-utwsxnywtlln
branch
from
70b25a3 to
5b75d94
Compare
|
Looks good, thank you 👍 |
|
|
||
| $enumClassName = $classConstFetch->class->toString(); | ||
| if (! $this->reflectionProvider->hasClass($enumClassName)) { | ||
| if ($this->isUsedOutsideOfProject($classConstFetch->class)) { |
There was a problem hiding this comment.
self should can be recefenced to current classreflection name, if it is ThisType, should be utilze $type->getStaticObjectType() so can look up correct target name.
There was a problem hiding this comment.
self should can be recefenced to current classreflection name
If the rector is processing self then it should be guaranteed to be a path used in withPaths
There was a problem hiding this comment.
Ok, let see it in the wild :),
/cc @marcelthole @boesing in case you have a chance to test latest "rector/rector": "dev-main" for EnumCaseToPascalCaseRector rule :)
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
3 participants
Hello!
This fixes some more bugs in the rector:
selfwere not being renamedThanks!